Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

chore: migrate to main branch#175

Merged
gcf-merge-on-green[bot] merged 5 commits intomainfrom
to_main
Aug 25, 2021
Merged

chore: migrate to main branch#175
gcf-merge-on-green[bot] merged 5 commits intomainfrom
to_main

Conversation

@dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Aug 24, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #174 🦕

@dandhlee dandhlee requested a review from parthea August 24, 2021 04:01
@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 04:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@product-auto-label product-auto-label bot added the api: cloudiot Issues related to the googleapis/python-iot API. label Aug 24, 2021
parthea
parthea reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One observation, otherwise LGTM.

@dandhlee dandhlee changed the title docs: migrate to main branch chore: migrate to main branch Aug 24, 2021
@dandhlee
Copy link
Contributor Author

dandhlee commented Aug 24, 2021

Please take a look!

@dandhlee dandhlee requested a review from parthea August 24, 2021 22:07
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Aug 25, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 25, 2021
@dandhlee
Copy link
Contributor Author

dandhlee commented Aug 25, 2021

@parthea I think there's an interesting relationship between "if sample files are touched we'll add Samples tests" and "there aren't enough sample files touched so I won't run these presubmits". I've been manually triggering these but might be worthwhile investigating why they're not getting automatically triggered.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 9168622 into main Aug 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the to_main branch August 25, 2021 17:30
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2021
@parthea parthea mentioned this pull request Aug 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joeklemm joeklemm

Labels

api: cloudiot Issues related to the googleapis/python-iot API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to main branch

4 participants

@dandhlee @parthea @joeklemm @yoshi-kokoro